AMQP websocket implementation #23722

rakshith91 · 2022-03-29T06:07:57Z

No description provided.

check-enforcer · 2022-03-29T06:18:01Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/message.py

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_connection.py

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_connection_async.py

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_transport_async.py

yunhaoling

This looks great in general, thanks for your efforts into it! -- left some minor comments

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/sasl.py

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_connection_async.py

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_sasl_async.py

swathipil · 2022-04-26T21:27:30Z

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_connection.py

@@ -78,10 +83,14 @@ def __init__(self, endpoint, **kwargs):
        self.state = None  # type: Optional[ConnectionState]

        transport = kwargs.get('transport')
+        self._transport_type = kwargs.pop('transport_type')


no default, or required keyword?

I agree - is there a reason this appears to be required?

A transport_type is always passed to a connection by the client. I can make it optional neverthless

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_connection.py

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py

swathipil · 2022-04-26T21:32:36Z

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py

@@ -653,5 +652,77 @@ def Transport(host, connect_timeout=None, ssl=False, **kwargs):
    Given a few parameters from the Connection constructor,
    select and create a subclass of _AbstractTransport.
    """
-    transport = SSLTransport if ssl else TCPTransport
+    transport_type = kwargs.pop('transport_type')


no default on purpose?

same as async

yep - transport_type is always passed. Again, it's not publicly exposed

hmm I think we could be more intentional about that. It's currently treated as a required parameter in multiple places, but is never described as such. I don't like relying on just because it's currently "always passed in". If that is the case - let's just make it explicit.
I would say make it required in one place - probably the transport seems like a good fit - and actually make it a positional parameter. Then at the Connection layer or the Client layer we implement the correct "default" logic that gets passed in.

swathipil

version + changelog updates? I think you might not have the latest updates on your branch, b/c changelog doesn't include 5.8.0a1-3?

update: oh looks like you're merging into the eh/pyproto branch? I think Adam has actually been working on the feature/eventhub/pyproto branch?

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_connection.py

annatisch · 2022-04-28T22:54:10Z

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_connection.py

@@ -78,10 +83,14 @@ def __init__(self, endpoint, **kwargs):
        self.state = None  # type: Optional[ConnectionState]

        transport = kwargs.get('transport')
+        self._transport_type = kwargs.pop('transport_type')


I agree - is there a reason this appears to be required?

annatisch · 2022-04-28T23:00:45Z

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py

@@ -653,5 +652,77 @@ def Transport(host, connect_timeout=None, ssl=False, **kwargs):
    Given a few parameters from the Connection constructor,
    select and create a subclass of _AbstractTransport.
    """
-    transport = SSLTransport if ssl else TCPTransport
+    transport_type = kwargs.pop('transport_type')


hmm I think we could be more intentional about that. It's currently treated as a required parameter in multiple places, but is never described as such. I don't like relying on just because it's currently "always passed in". If that is the case - let's just make it explicit.
I would say make it required in one place - probably the transport seems like a good fit - and actually make it a positional parameter. Then at the Connection layer or the Client layer we implement the correct "default" logic that gets passed in.

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_sasl_async.py

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_transport_async.py

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/constants.py

annatisch · 2022-04-28T23:10:07Z

sdk/eventhub/azure-eventhub/tests/pyamqp_tests/synctests/test_websocket.py

+from azure.eventhub._pyamqp import authentication, ReceiveClient
+from azure.eventhub._pyamqp.constants import TransportType
+
+def test_event_hubs_client_web_socket(live_eventhub):


Async test?
And maybe some kind of test for the proxy settings?

https://github.com/Azure/azure-uamqp-python/pull/323/files#diff-7ef7f7a671052d98771c46e57dc5b5fa98775fbe1e2e394d71df21cc25c792df

for proxy, CI doesn't support it - running this sample locally using https://github.com/abhinavsingh/proxy.py
https://github.com/Azure/azure-sdk-for-python/blob/feature/eventhub/pyproto/sdk/eventhub/azure-eventhub/samples/sync_samples/proxy.py

We can also use mocked offline tests for this kind of thing to at least ensure the correct code path is followed with the correct parameters.

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_client_async.py

rakshith91 · 2022-05-05T06:29:28Z

/azp run python - eventhub - ci

azure-pipelines · 2022-05-05T06:29:48Z

Azure Pipelines successfully started running 1 pipeline(s).

swathipil

I think you'll need to update the changelog + version (to a4 not b4, which is what I bumped the version to 🤦)

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_connection.py

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_connection_async.py

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/client.py

swathipil

LGTM!

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_transport_async.py

This reverts commit 0123f4d.

rakshith91 · 2022-05-07T07:52:51Z

Clicked merge by mistake - #24345

made one small change in this PR

* Initial implementation * http proxy support * change impl * more changes * working sol * async impl * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * more changes * sasl mixin * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/message.py * refactor * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * oops * comments * comment * Apply suggestions from code review Co-authored-by: swathipil <[email protected]> * comments * changes * async test * rasie * lint * changelog * version * comments * move path to EH Co-authored-by: swathipil <[email protected]>

This reverts commit 0123f4d.

* [EventHub] basic receive event scenario with pyamqp (#19748) * initial changes for receiving * undo __init__ aio * vendor * remove c/pyx files * adams comments * [EventHubs & AMQP Python] Send Port (#19745) * draft send port * copy and paste code changes in amqp * simple stress test scripts for sending and receiving * review feedbacks * [EventHubs&AMQP Python] Port amqp send large message (#19937) * port amqp send large message * send perf test in parallel * use context manager for executor * add throughput * improve test code * update test matrix * update test * handle server busy * fix timeout * precision to 2 decimal points * update pyamqp changes and update tests * [EventHubs] Pure Python AMQP Sycn Implementation Integration (#22397) * copy amqp changes * eh python amqp integration * fix time unit * rename module pyamqp to _pyamqp * more pyamqp to _pyamqp * simplify todo * [EH Pyproto] Release preparation (#22433) * cherry pick changes * update docs * cherry pick fixed retry PR * minor fix * fix mypy, pylint, brokenlink * update doc * opt out mypy/pylint/api stub * try opt out checkpointstore in ci and test * fix * more fixes * furuther opt out tests * update tests * bump version * fix __str__ * add test play holder * ignore azure checkpoinstore aio in ci Co-authored-by: swathipil <[email protected]> * update readme to drop uamqp * revert async tests * revert aio module in eventhub * [EH Pyproto] Async support (#22957) * async port * add scripts for tests * update async perf test scripts * fix test scripts * amqp implementation update + eh update + sync perf test scripts * update pyamqp and eh async impl and test scripts * update pyamqp async impl * fix bug * fix pyamqp transport ssl setting and asyncio exception module import * use ensure future for 3.6 * update token generation to return bytes to avoid breaking changes * update docs * Increment version for eventhub releases (#22994) Increment package version after release of azure-eventhub * [EH Pyproto] Async recv perf improvement (#23122) * stop spawning too much coroutines * improve send * async recv perf improvement * async perf improve * update version * align with sync imple * update method name * remove redundant except catch * [EH Pyproto] Release updates (#23349) * update docs * add todo * Increment version for eventhub releases (#23420) Increment package version after release of azure-eventhub * AMQP websocket implementation (#23722) * Initial implementation * http proxy support * change impl * more changes * working sol * async impl * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * more changes * sasl mixin * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/message.py * refactor * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * oops * comments * comment * Apply suggestions from code review Co-authored-by: swathipil <[email protected]> * comments * changes * async test * rasie * lint * changelog * version * comments * move path to EH Co-authored-by: swathipil <[email protected]> * Revert "AMQP websocket implementation (#23722)" (#24344) This reverts commit 0123f4d. * AMQP websocket implementation (#24345) * Initial implementation * http proxy support * change impl * more changes * working sol * async impl * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * more changes * sasl mixin * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/message.py * refactor * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * oops * comments * comment * Apply suggestions from code review Co-authored-by: swathipil <[email protected]> * comments * changes * async test * rasie * lint * changelog * version * comments * move path to EH * Fix typo Co-authored-by: swathipil <[email protected]> * [EventHub] basic receive event scenario with pyamqp (#19748) * initial changes for receiving * undo __init__ aio * vendor * remove c/pyx files * adams comments * [EventHubs & AMQP Python] Send Port (#19745) * draft send port * copy and paste code changes in amqp * simple stress test scripts for sending and receiving * review feedbacks * [EventHubs&AMQP Python] Port amqp send large message (#19937) * port amqp send large message * send perf test in parallel * use context manager for executor * add throughput * improve test code * update test matrix * update test * handle server busy * fix timeout * precision to 2 decimal points * update pyamqp changes and update tests * [EventHubs] Pure Python AMQP Sycn Implementation Integration (#22397) * copy amqp changes * eh python amqp integration * fix time unit * rename module pyamqp to _pyamqp * more pyamqp to _pyamqp * simplify todo * [EH Pyproto] Release preparation (#22433) * cherry pick changes * update docs * cherry pick fixed retry PR * minor fix * fix mypy, pylint, brokenlink * update doc * opt out mypy/pylint/api stub * try opt out checkpointstore in ci and test * fix * more fixes * furuther opt out tests * update tests * bump version * fix __str__ * add test play holder * ignore azure checkpoinstore aio in ci Co-authored-by: swathipil <[email protected]> * update readme to drop uamqp * revert async tests * revert aio module in eventhub * [EH Pyproto] Async support (#22957) * async port * add scripts for tests * update async perf test scripts * fix test scripts * amqp implementation update + eh update + sync perf test scripts * update pyamqp and eh async impl and test scripts * update pyamqp async impl * fix bug * fix pyamqp transport ssl setting and asyncio exception module import * use ensure future for 3.6 * update token generation to return bytes to avoid breaking changes * update docs * Increment version for eventhub releases (#22994) Increment package version after release of azure-eventhub * [EH Pyproto] Async recv perf improvement (#23122) * stop spawning too much coroutines * improve send * async recv perf improvement * async perf improve * update version * align with sync imple * update method name * remove redundant except catch * [EH Pyproto] Release updates (#23349) * update docs * add todo * Increment version for eventhub releases (#23420) Increment package version after release of azure-eventhub * AMQP websocket implementation (#23722) * Initial implementation * http proxy support * change impl * more changes * working sol * async impl * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * more changes * sasl mixin * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/message.py * refactor * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * oops * comments * comment * Apply suggestions from code review Co-authored-by: swathipil <[email protected]> * comments * changes * async test * rasie * lint * changelog * version * comments * move path to EH Co-authored-by: swathipil <[email protected]> * Revert "AMQP websocket implementation (#23722)" (#24344) This reverts commit 0123f4d. * AMQP websocket implementation (#24345) * Initial implementation * http proxy support * change impl * more changes * working sol * async impl * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * more changes * sasl mixin * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/message.py * refactor * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * oops * comments * comment * Apply suggestions from code review Co-authored-by: swathipil <[email protected]> * comments * changes * async test * rasie * lint * changelog * version * comments * move path to EH * Fix typo Co-authored-by: swathipil <[email protected]> * remove extra SR related code * update docs + type hints * fixing failing tests * [EventHubs] merge working websocket changes to feature branch (#24444) * adam's working changes * Adding back Rakshith's websocket changes (#24410) * Adding back Rakshith's sync websocket changes * fix async send and receive * fix transport bugs * add websocket to dev reqs + async fix hostname * thank you kashif * fix tests + turn on websocket tests * update consumer test timing * fix merge bugs + remove pyamqp specific tests * update sleep time in test * enable live test for ws receive * fix to create Batch properly * [eventhub] Websocket timeout error exception thrown (#24504) * sync websocket timeout to operationtimeout, not changing other transport types just yet * async websocket to operation timeout * upstream * default timeout 1.0 * default timeout 1 * throwing a socket timeout, operationtimeout was throwing out a real error * replacing socket.timeout with TimeoutError, added into except statments as well * timeout is inherited from oserror, dont need both * test timeoutexception throwing errors * deafult timeout to 1 * [eventhub] websocket default timeout fix (#24565) * websocket timeout fix * timeout interval for both ssl and webscoket * [eventhub] Custom Endpoint (#24505) * sync ce * async ce * add string ending * only pass to transport * running into same recieve issue with sync * fixing async - needs to pass to sasl * remove logger * stopping here * adding prefix to fix sample * add in prefetch * fixing transport remove print * host being overriden * removing trace * fix to use url async * aligning sync/async pattern * removing uneeded hostname switch * string formatting * changelog * adding docstrings for supported events * pr comments refactoring sync * mirroring on async * pr comment docstring * removing import * missing _ * missing ssl * if no port given, we use default set in config * async of same ^ * add default port in connection stage if port is none * adding in docstring to cliet/connection string constructor * custom_endpoint_address in client base async to match sync * fix import on websocket test * fix import 2 * skipping tests * removing import * pytest.mark * [EventHubs] pyproto - update release date + docs (#24723) * add async doc rst file * Increment version for eventhub releases (#24753) Increment package version after release of azure-eventhub * changes to update status (#25024) * updating codeowners file in pyproto feature * [Eventhub] pyamqp prefetch fix (#24890) * prefetch fix * adding async - sorry! * async * Use --no-cone in pipeline sparse checkout script (#25165) (#25208) Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> * [AMQP Python] Eventhub Pyamqp tests (#24895) * starting tests * updates to websocket sync * moving around format - unittest and live test * live test + unittests starting * websocket async passing * eol * assert not return * assert not return * fixed assert * auth tests * auth unittest pyamqp * replicating uamqp tests * keep_alive_thread * skip for now - no keep alive * pickle/deepcopy, might not want to keep all * stopping here for now - need tls on rabbitmq * cleaning up tests - pickle * removing and editing uneeded tests * removing unused test * added receive amqp tests * exceptions with pytest.raises, not live * moving around tests * testing mgmt calls like _start_producer * Use --no-cone in pipeline sparse checkout script (#25165) Co-authored-by: Ben Broderick Phillips <[email protected]> * unused imports Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> * [Pyamqp] Fix network logging trace in client_base (#25218) * pass in right kwarg for network tracing * remove client changes. Another PR * reverting link credit for now (#25310) * [Pyamqp] Pyampq debug build Linkedin (#25296) * enhanced logging for linkedin * stuff * fixes * minor sample fix * Changelog * remove unused imports * fix formatting changes * change debug level * update version info * update changelog * fix sample * fix logging message for empty access token * Increment version for eventhub releases (#25320) Increment package version after release of azure-eventhub * removing duplicate (#25321) * add async unit tests (#25396) * reset logging level (#25588) * [Pyamqp] Remember Proxy Params (#25564) * fix to keep proxy params * async changes for proxy * unit tests * changes * more changes Co-authored-by: swathipil <[email protected]> Co-authored-by: swathipil <[email protected]> * [Pyamqp] Intial TODOS Clean Up (#25630) * set default SSL version * dont need it for EH & SB * wont impact us, check mtg notes * decode error wont affect us * address in SB PR * change language on logger * it does close socket * no other closes needed * keep for better tracking * close w/ error when max frame size is invalid * detach links on session end * clean up links on session outgoing_end * reject link by detaching * uncomment logging for later review * reject the link that was set in the try * [Pyamqp] test fixes for pipeline (#25749) * test fixes for pipeline * connect to EHerror * [PyAMQP] Stress testing reform (#25770) * reform stress test * reform stress test * updating stress test format * can specify azure_identity on producer * epoch level sync * removing commands * aligning sync/async * pyamqp logging * uamqp to pyamqp * import remove * fixing deploy commands * values file * checking eng/ file resources * remove version * moving location of this folder * imagepullpolicy, azure_identity for consumer * [PyAMQP] Updating pyamqp with SB changes (#25804) * pyamqp diff from anna's branch * mgmt_request returns code, response, desc * mgmt_request returns code, response, desc async * handle error being thrown * handle error being thrown 2 * handle error being thrown 3 * Fixed error path * fix error path Co-authored-by: Anna Tisch <[email protected]> Co-authored-by: Kashif Khan <[email protected]> * removing buff producer to add back in later * update cspell * fix uppercase link in doc/dev/issues/resolve_issues_effectively * [PyAMQP] Connections TODO (#26018) * protocol errors * fix formatting * [PyAMQP] Kashif Client refactoring changes (#25451) Linked to link #22051 for a TODO about typing in docstrings * need to use pyamqp (#25895) * [EventHubs] add amqp switch support (#25965) This PR is for adding switch support to the `feature/eventhub/pyproto` changes including the uamqp switch from current `main`. fixes #21246 Addressing Anna's comments from uamqp switch PR (#25193) + main changes: - [x] Moving pyamqp logic out to the PyamqpTransport - [x] **Confirmed: The size of encoded pyamqp.Message is larger than uamqp.Message.** I thought otherwise b/c I was adding the header/property objects by default when building the outgoing uamqp message, even if all values inside those are None. I've fixed this. - [ ] Make BatchMessage transport agnostic: #25494 (comment) - Instead, updated EventDataBatch so that it takes an amqp_transport. If EventDataBatch is manually created and uses PyamqpTransport, inside `send_batch()`, if the producer client transport uses UamqpTransport, the BatchMessage corresponding to the client's amqp_transport will be built and sent. - [X] Add `message` property to `EventData`/`EventDataBatch`, which return `LegacyMessage`/`LegacyMessageBatch` from `_pyamqp` for backcompat. - [x] add `connection=None` parameter to `pyamqp.AMQPClient.open()` as per [this discussion](#25494 (comment)) - [x] Add an async SharedConnectionManager in pyamqp: #25494 (comment) Issue created [[here](#25875)] to address the below TODOs in a separate PR: - [x] add TODO in pyamqp that SenderClient should take msg_timeout: #25494 (comment) - [x] add TODO in pyamqp that ReceiveClient should take timeout: #25494 (comment) - [x] add both MAX_MESSAGE_LENGTH_BYTES and MAX_FRAME_SIZE_BYTES to pyamqp: #25494 (comment) TODO: - [ ] fix mypy/pylint issues - made partial progress. fix rest in separate PR for issue: #25936 - [x] investigate how to remove `message` property from public API. - mark as deprecated and log a deprecation warning if accessed * prep release * [Pyamqp] Exception Todos (#25893) * throw proper exception and error condition on CBS * error condition for ready * close when open is on non-zero channel * error condition is proper for timeout * unattached handle * max handles error condition * fix strings * fix * end the session on unattached handle * remove TODO * conditions are proper * raise link error on close or detach * revert change * remove TODO * change to client error * change to AmqpError * change to AMQPError * detach called * detach the link, dont close the connection * comments clean up + change condition * handle invalid channel on end * descriptive error message * fix formatting * detach err message on max handle * [Pyamqp] Async WS implementation using a pure async library (#26234) * init changes for aiohttp ws * fixes + formatting * fixes for context manager * changes * ssl options * clean up * move build opts in to mixin * pass in proxy information * attach port to proxy if given * address comments * remove self from proxy host * [SB PyAMQP] Servicebus PyAMQP Working off of Anna's Branch (#24975) * Added pyamqp * Added message compatibility tests * Start rewiring messages for pyamqp * Added message backcompat layer * Successful message send * Started receiver * Successful message receive * Message settlement * Fix other settlement outcomes * Make tests live * message partition_key if it can't be decoded - output value * removing references to __future___ annotations for now - not supported in 3.6 * comparing name of transport - not the object * passing in a dummy frame for new formatting of SBMessageReceived * adding in fake frame for message in queue tests * uamqp_mesage -> uamqp_message * state should be auth_state * switching this back - _message is Message * Improved typing * Revert "Improved typing" This reverts commit aeffcb2. * Fix TransportType enum * Fix import statement * Fix application property encoding * Skip queue iterator tests * Fix mgmt op timeout * Fixes to mgmt link * Fix frame decode tests * More mgmt fixes * Some message fixes * Fix session filters * Message tests * Skip more iterator tests * Update to retry policy * adding in support for websockets is CE supported? * fixing up pylint-still some issues * some more pylint/TODOs * pylint changes * fixing pylint * more pylint connection * More test fixes * Fix scheduling * Fix retry test * Fix error handling * Sender refactor for timeout * Fix link detach * Fixed receiver control flow * Update pyamqp async code * Updated sb async * Typing fix * Some async fixes * Skip async iter tests * Workaround socket timeout * Literal import * More async test fixes * Added keepalive * Pylint cleanup * fix mypy errors in _pyamqp * fix mypy sb layer * fix bug * unused import * lint * fix failing tests * ignore sb iterator receive samples Co-authored-by: antisch <[email protected]> Co-authored-by: swathipil <[email protected]> * [Pyamqp] Pyamqp fix conn (#26568) * remove unnecessary pops * fix var name + remove unnecessary pop * fix * Bring in changes to fix bandit from failing * [EventHubs&ServiceBus] merge sb and eh pyamqp (#26548) * merge sb and eh pyamqp * reenable pylint for EH * turn on mypy for EH * fix mypy errors eh layer * fix EH mypy/pylint * fix SB failing tests * fix more tests/mypy * import literal from typing extensions * remove whitespace * fix typing cast bug in EH * lint * fix port url in async transport * kashifs comments * mypy/lint/kashifs comments * [Pyamqp] Fix Async Invalid Host Error Test (#26595) * resert transport to original state * add in missing continue in except * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_transport_async.py Co-authored-by: swathipil <[email protected]> Co-authored-by: swathipil <[email protected]> * fix merge conflict stress * update cspell, ignore tables spelling * skip connection verify tests sb for now * fix logging formatting (#26682) * copy over kashifs change to sb * [ServiceBus&EventHubs] pyamqp - update EH/SB docs for release (#26741) updating docs to prepare for release * [ServiceBus&EventHubs] fix mypy/pylint (#26744) * fix mypy/pylint * bump SB version * prep release alpha (#26755) * Increment version for servicebus releases (#26762) Increment package version after release of azure-servicebus * Increment version for eventhub releases (#26766) Increment package version after release of azure-eventhub * [PyAMQP] Fix logging (#26785) * make logging network trace a debug level log * async changes * await async sleep (#26853) * fix for async socket (#26852) * [Pyamqp] Possible solutions for network disruption using async websocket (#26856) * heartbeat * constant value for heartbeat * address comments * [Pyamqp] Fix to Improve Websocket Sync and Async Network Disruption Handling (#27006) * changes * fix lint * remove prints * remove unused import * remove heartbeat from this PR * [pyAMQP] Stress fixes for aiohttp and valueError (#27034) * changes * fix lint * remove prints * remove unused import * remove heartbeat from this PR * OS Error to catch client closed session error * removing value error raise, change to logging -- causes error on network disconnect * when looping on open clinet * change to printf style Co-authored-by: Kashif Khan <[email protected]> * [Pyamqp] Changes for blocking exceptions (#27260) * changes for blocking exceptions * fix hang on unit test * lint fixes * fix bug for closes * fixes * lint issues * Stress testing updates (#27456) * can uncomment line 5 to run against git version of pyamqp * can move line 6 into scripts/dev_requirement file * test against newest version of pyamqp * increase test time, get rid of unused tests * removing test names * change naming * change naming * raise logging level to catch only error level * return logging to info * adding resource requests * message retention needs to last as long as the test * websocket async test * changing life of messages * 32 partitions * add uamqp flag - remove logging * adding before trying matrix * websocket dep * helm ignore * updating * updating tests * update consumer files * remove log lines * remove log lines * remove commented * update * [EventHubs] kwargs/error testing (#27065) * adding tests * add auth/connection tests + fixes * fix connection verify error handling * revert consumer retry change * call ws close in sync transport * typo * fix ws exc import * fix async transport * fix link detach vendor error exception parity * add operationtimeouterror * add more negative tests * annas comments + lint * lint + tests * add ids for uamqp vs pyamqp tests * update tests * skip macos tests * [EventHubs] check for any non-None values in amqp header/properties (#27444) * add any method to amqp header/properties * use count(None) to check non-None header/props vals * [EventHubs] update sync receive client ready flow (#27411) * update sync receive client ready flow * lint + mypy * fix reconnect test * [pyamqp] os error add (#27351) * os error add * update except statement * test mock of receive_bytes on pipeline * client os error * mock try 2 * pylint * fix patch line * fixed mock * newline * fixing spacing * unused import * fix error mssgs * changes from perf run (#27703) * Matrix Gen Stress Tests (#27754) * stress matrix gen * removing unused dockerfiles for now * revert sb to main * revert non-eh files * restore samples/readmes to main * restore ci/tests/shared reqs to main * update to stable * lint + fix tests for no uamqp import * update test timeout * re-organize changelog Co-authored-by: Adam Ling (MSFT) <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Rakshith Bhyravabhotla <[email protected]> Co-authored-by: Kashif Khan <[email protected]> Co-authored-by: Libba Lawrence <[email protected]> Co-authored-by: Kashif Khan <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Anna Tisch <[email protected]>

[NetAppFiles]Anf 27235 update for 2022 11 01 (Azure#23722) * Add new folder * Add 2022-11-01 changes * Update api-version in examples * Update readme * Validation * operation id and response header * netAppAccountPatch add identity * use commontypes param v3 not v2 * Extend managedIdentity to add tennantId to userassigned to fix s360 * remove format * manged identithy * error response model from common types * Revert override of managedServiceIdeneity

ghost added the Event Hubs label Mar 29, 2022

rakshith91 marked this pull request as ready for review April 19, 2022 05:18

rakshith91 requested review from annatisch, yunhaoling and swathipil as code owners April 19, 2022 05:18

rakshith91 commented Apr 19, 2022

View reviewed changes

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py Outdated Show resolved Hide resolved

rakshith91 commented Apr 19, 2022

View reviewed changes

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/message.py Outdated Show resolved Hide resolved

rakshith91 commented Apr 19, 2022

View reviewed changes

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py Outdated Show resolved Hide resolved

rakshith91 commented Apr 19, 2022

View reviewed changes

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py Outdated Show resolved Hide resolved

rakshith91 commented Apr 19, 2022

View reviewed changes

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py Outdated Show resolved Hide resolved

yunhaoling reviewed Apr 21, 2022

View reviewed changes

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_connection.py Outdated Show resolved Hide resolved

yunhaoling reviewed Apr 21, 2022

View reviewed changes

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py Outdated Show resolved Hide resolved

yunhaoling reviewed Apr 21, 2022

View reviewed changes

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py Outdated Show resolved Hide resolved

yunhaoling reviewed Apr 21, 2022

View reviewed changes

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_connection_async.py Outdated Show resolved Hide resolved

yunhaoling reviewed Apr 21, 2022

View reviewed changes

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_transport_async.py Outdated Show resolved Hide resolved

yunhaoling reviewed Apr 21, 2022

View reviewed changes

kashifkhan reviewed Apr 26, 2022

View reviewed changes

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py Outdated Show resolved Hide resolved

kashifkhan reviewed Apr 26, 2022

View reviewed changes

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/sasl.py Outdated Show resolved Hide resolved

swathipil reviewed Apr 26, 2022

View reviewed changes

rakshith91 mentioned this pull request Apr 26, 2022

tranport method name should be snake cased. It's currently Transport #24197

Closed

swathipil reviewed Apr 27, 2022

View reviewed changes

annatisch reviewed Apr 28, 2022

View reviewed changes

rakshith91 changed the base branch from eh/pyproto to feature/eventhub/pyproto May 4, 2022 22:03

rakshith91 added 6 commits May 4, 2022 15:36

Initial implementation

b9ac853

http proxy support

845cd16

change impl

4f524b1

more changes

5d42efc

working sol

4eba1c1

async impl

3ce869e

rakshith91 force-pushed the webso branch from f846fea to e9d9486 Compare May 4, 2022 22:41

changes

e04f18c

rakshith91 commented May 4, 2022

View reviewed changes

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_client_async.py Show resolved Hide resolved

async test

50e8594

rakshith91 mentioned this pull request May 5, 2022

We could look at providing a TypedDict for this. Not important right now though. #24306

Closed

rakshith91 added 2 commits May 5, 2022 00:27

rasie

eb8cdc0

lint

4f76905

swathipil reviewed May 5, 2022

View reviewed changes

rakshith91 added 2 commits May 5, 2022 11:33

changelog

0db10f8

version

17df37e

swathipil reviewed May 5, 2022

View reviewed changes

swathipil approved these changes May 5, 2022

View reviewed changes

annatisch reviewed May 5, 2022

View reviewed changes

rakshith91 added 2 commits May 5, 2022 14:32

comments

ac822f4

move path to EH

d351b5a

rakshith91 merged commit 0123f4d into Azure:feature/eventhub/pyproto May 7, 2022

rakshith91 added a commit that referenced this pull request May 7, 2022

Revert "AMQP websocket implementation (#23722)"

2a601e8

This reverts commit 0123f4d.

rakshith91 mentioned this pull request May 7, 2022

Revert "AMQP websocket implementation" #24344

Merged

rakshith91 added a commit that referenced this pull request May 7, 2022

Revert "AMQP websocket implementation (#23722)" (#24344)

bcab241

This reverts commit 0123f4d.

kashifkhan pushed a commit to kashifkhan/azure-sdk-for-python that referenced this pull request May 10, 2022

Revert "AMQP websocket implementation (Azure#23722)" (Azure#24344)

7305718

This reverts commit 0123f4d.

This was referenced May 12, 2022

Adding back Rakshith's websocket changes #24410

Merged

[AMQP Python] add async keep_worker_alive to async client #24411

Closed

swathipil pushed a commit to swathipil/azure-sdk-for-python that referenced this pull request Aug 23, 2022

Revert "AMQP websocket implementation (Azure#23722)" (Azure#24344)

f63f352

swathipil pushed a commit to swathipil/azure-sdk-for-python that referenced this pull request Aug 23, 2022

Revert "AMQP websocket implementation (Azure#23722)" (Azure#24344)

8e3c43e

This reverts commit 0123f4d.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AMQP websocket implementation #23722

AMQP websocket implementation #23722

rakshith91 commented Mar 29, 2022

check-enforcer bot commented Mar 29, 2022

yunhaoling left a comment •

edited

Loading

swathipil Apr 26, 2022

annatisch Apr 28, 2022

rakshith91 May 1, 2022

swathipil Apr 26, 2022

rakshith91 Apr 26, 2022

rakshith91 Apr 26, 2022

annatisch Apr 28, 2022

swathipil left a comment •

edited

Loading

annatisch Apr 28, 2022

annatisch Apr 28, 2022

annatisch Apr 28, 2022

rakshith91 May 4, 2022

rakshith91 May 5, 2022

annatisch May 5, 2022

rakshith91 commented May 5, 2022

azure-pipelines bot commented May 5, 2022

swathipil left a comment

swathipil left a comment

rakshith91 commented May 7, 2022

AMQP websocket implementation #23722

AMQP websocket implementation #23722

Conversation

rakshith91 commented Mar 29, 2022

check-enforcer bot commented Mar 29, 2022

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

yunhaoling left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

swathipil left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rakshith91 commented May 5, 2022

azure-pipelines bot commented May 5, 2022

swathipil left a comment

Choose a reason for hiding this comment

swathipil left a comment

Choose a reason for hiding this comment

rakshith91 commented May 7, 2022

yunhaoling left a comment •

edited

Loading

swathipil left a comment •

edited

Loading